Allon Mureinik has submitted this change and it was merged. Change subject: engine: Forbid star imports ...................................................................... engine: Forbid star imports By the project's conventions (which are enforced by code review) * imports are not allowed. This patch adds a checkstyle validation to ensure these errors are caught at build time instead of review time. Change-Id: I62cd280184ad2baf8ad8298b32b0a1f61d4bc0b2 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62cd280184ad2baf8ad8298b32b0a1f61d4bc0b2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>