Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove ListUtils.nullSafe[Element]Add ...................................................................... engine: Remove ListUtils.nullSafe[Element]Add ListUtils.nullSafeElementAdd was only used in ConfigureLocalStorageModel, and could easily be replaced: - notAvailableNumberList is known to not be null, as it's created a few lines before this call - The integer value isn't intrinsically null, it's just created by a failure to parse a string, which could be handled in a much more readable fashion by catching the NumberFormatException explicitly. This patch removes: - The only real usage of nullSafeElementAdd, as described above - The now unused ListUtils.nullSafeElementAdd and ListUtils.nullSafeAdd - The unit test for those methods Change-Id: I31fdcaf977fc125a5ae57906659f75cf7149b318 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 3 files changed, 6 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31fdcaf977fc125a5ae57906659f75cf7149b318 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>