Change in ovirt-engine[master]: Extended Correlation ID capability and logging

From Martin Peřina <mperina@redhat.com>:
Martin Peřina has submitted this change and it was merged. Change subject: Extended Correlation ID capability and logging ...................................................................... Extended Correlation ID capability and logging This patch introduces the correlation id (CID) tracking for queries. All incoming Rest API and Gwt RPC Api endpoints are now equipped with the Correlation-Id header feature which allows an API user to assign a CID in the request headers. If the header is not present, the engine will generate for each request a new CID. The used CID is passed back in the response as the Correlation-Id header in the response. Additionally to the header, the CID can now be also passed in as correlation_id query parameter, which might be most interesting to the REST Api All queries are now logging the time spent and print the configured CID. This feature has been added with the intend to allow better analysis of slow tasks which come in through the REST API and/or the GWT RPC API. Bug-Url: https://bugzilla.redhat.com/1347631 Change-Id: I67b45c14649bec21b2772f545bfde75aec9349b0 Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/HasCorrelationId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/invocation/CurrentFilter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 12 files changed, 173 insertions(+), 23 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/61986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67b45c14649bec21b2772f545bfde75aec9349b0 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review