Arik Hadas has submitted this change and it was merged. Change subject: frontend: refactor VmListModel#onSave method ...................................................................... frontend: refactor VmListModel#onSave method Extract code from VmListModel#onSave to two separate methods: - saveNewVm which adds VM as new entity - updateExistingVm which updates existing VM entity It makes the code more maintainable, as the onSave method was too long and had too many responsibilities. Change-Id: I90a0164146fd17eb2dced71699bbf3d8ac489004 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 185 insertions(+), 183 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90a0164146fd17eb2dced71699bbf3d8ac489004 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server