Muli Salem has submitted this change and it was merged. Change subject: engine: Prevent networks with different MTU (#852052) ...................................................................... engine: Prevent networks with different MTU (#852052) https://bugzilla.redhat.com/852052 The patch prevents attaching a network to an interface if one of the following cases occur: * A non-VM network is already attached to the interface with MTU other than default and the user attempt to attach a Vlan which its MTU is other than the non-VM network. * A Vlan with non-default MTU is attached to an interface and the user attempt to attach a non-VM network to it with MTU other than the Vlan. Attaching several Vlans (VM network) with different MTU will not be blocked, as VDSM should support MTU configuration for the underlying interface. Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83 Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 360 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/7661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Muli Salem <msalem@redhat.com>