Juan Hernandez has submitted this change and it was merged. Change subject: cli: Stop infinite recursion when expanding types ...................................................................... cli: Stop infinite recursion when expanding types Currently the method that expands nested types doesn't take into account that the types may be recursive, thus there is potential for an infinite recursion. This actually happens with the "HostNIC" broker class which constructor has the following declaration: def __init__(self, host, hostnic, context): Currently when the CLI processes this method it will try to expand the "host" and "hostnic" types, then it will find that the "hostnic" parameter corresponds to the "HostNIC" broker, and will process it again, recursively. To stop this infinite recursion this patch changes the CLI so that it will check for this condition and stop the recursion. Change-Id: I63c741f428eb7fdd266f067dbd662f217dcae431 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M src/ovirtcli/utils/methodhelper.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63c741f428eb7fdd266f067dbd662f217dcae431 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: automation@ovirt.org