Allon Mureinik has submitted this change and it was merged. Change subject: core: Move generic getValue to ConfigUtilsBase ...................................................................... core: Move generic getValue to ConfigUtilsBase Moved the generic getValue implementation to ConfigBaseBase to create a better separation of layers - ConfigUtilsBase deals with all the logic regarding parsing values, handling defaults, etc, and DbConfigUtils adds only its DB specific bits - retrieving from the database, caching, etc. Change-Id: Ieada7dc63cdc394b5d3e9c031a324e0c986b0a2a Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ConfigUtilsBase.java 2 files changed, 119 insertions(+), 117 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieada7dc63cdc394b5d3e9c031a324e0c986b0a2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>