Juan Hernandez has submitted this change and it was merged. Change subject: packaging: changed override-firewall in firewall-manager ...................................................................... packaging: changed override-firewall in firewall-manager In engine-setup, changed the option override-firewall that the user may expect to be boolean into firewall-manager that accept "None", "Firewalld" or "IPtables" as values. Updated the output messages explaining the meaning of None as firewall manager. Change-Id: Ib5d92079a7caa301de248e90740e77fa5577b068 Bug-Url: https://bugzilla.redhat.com/901987 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py 2 files changed, 14 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5d92079a7caa301de248e90740e77fa5577b068 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Alex Lourie <alourie@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com>