Roy Golan has submitted this change and it was merged. Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores) ...................................................................... engine: validate (vm NUMA nodes) <= (vm CPU cores) Add validation in canDoAction(), in UpdateVmCommand. Validate (vm NUMA nodes> <= (vm CPU cores), even if called from REST api Generate a detailed error message: [Cannot edit VM. Assigned 2 NUMA nodes for 1 CPU cores. Cannot assign more NUMA nodes then CPU cores.] Bug-Url: https://bugzilla.redhat.com/1196235 Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Signed-off-by: Dudi Maroshi <dudi@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 71 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi@redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: automation@ovirt.org