Daniel Erez has submitted this change and it was merged. Change subject: core: tpgt should not be sent when empty ...................................................................... core: tpgt should not be sent when empty Ensure 'tpgt' isn't sent as an empty string as VDSM expects an integer. I.e. 'tpgt' is optional, but if specified, it must be an integer. Vdsm API: " {'type': 'IscsiConnectionParameters', 'data': {'portal': 'IscsiPortal', 'iqn': 'str', '*tpgt': 'int', '*iface': 'str', '*credentials': 'IscsiCredentials'}} @tpgt: #optional The Target Portal Group Tag to use " Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Bug-Url: https://bugzilla.redhat.com/1160785 Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server