From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: override applyLockProperties in SyncLUNs
......................................................................
backend: override applyLockProperties in SyncLUNs
The method applyLockProperties was not overridden by
SyncLunsInfoForBlockStorageDomainCommand and thus the exclusive lock
with the group SYNC_LUNS on the storage domain's id was never taken
before running this command.
Since we don't want two SyncLunsInfoForBlockStorageDomain commands to
run concurrently for the same block storage domain, this patch overrides
this method so that lock will be taken.
Change-Id: Ica5aad22abd354c94110ab14d371be6d63ef43b1
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit
https://gerrit.ovirt.org/77490
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica5aad22abd354c94110ab14d371be6d63ef43b1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>