Change in ovirt-engine[master]: core: AbstractVmNumaNodeCommand#vdsNumaNodeDao

Allon Mureinik has submitted this change and it was merged. Change subject: core: AbstractVmNumaNodeCommand#vdsNumaNodeDao ...................................................................... core: AbstractVmNumaNodeCommand#vdsNumaNodeDao This command already has an injected VdsNumaNodeDao instance, but there's also a getVdsNumaNodeDao() method that returns the instance provided by DbFacade. This patch cleans up the potentially buggy situation, and streamlines the code to use the injected instance. Change-Id: I2f5f5f42f9a10c0c466dba3f8e34cf8026fc90fa Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommandTestBase.java 2 files changed, 1 insertion(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f5f5f42f9a10c0c466dba3f8e34cf8026fc90fa Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
amureini@redhat.com