Itamar Heim has submitted this change and it was merged. Change subject: core: add helper method for template version ...................................................................... core: add helper method for template version some places in addVmTemplate command are checking for baseTemplateId==null to understand if we add base template or template version. this patch encapsulate this logic into a method with a clear name. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1075074 Change-Id: I25229303fcee443191be1f2a1de84be345f96aff Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25229303fcee443191be1f2a1de84be345f96aff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server