Change in ovirt-engine[master]: build: Configure checkstyle for the frontend

Tal Nisan has submitted this change and it was merged. Change subject: build: Configure checkstyle for the frontend ...................................................................... build: Configure checkstyle for the frontend This patch configures maven-checkstyle-plugin in frontend/pom.xml. Doing so has several advantages: 1. The plugin is configured once, and when authoring a new module under frontend the author doesn't need to think whether or not to configure this plugin, and if so how. 2. A lot of repetitive boiler-plate configuration is saved. 3. Mistakes where checkstyle is not run (as happened, e.g., in the bll and utils modules) are avoided. Change-Id: I2b4535529648dd71042072e4b8780d673a39b27b Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M frontend/pom.xml 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b4535529648dd71042072e4b8780d673a39b27b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
tnisan@redhat.com