Liron Aravot has submitted this change and it was merged. Change subject: core: avoid adding ovf store when register disk fails ...................................................................... core: avoid adding ovf store when register disk fails Trying to add an ovf store when the disk registration failed it will result in a low level sql error: ERROR: insert or update on table "storage_domains_ovf_info" violates foreign key constraint "storage_domains_ovf_info_ovf_disk_id_fkey" Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Signed-off-by: Federico Simoncelli <fsimonce@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Federico Simoncelli: Verified Maor Lipchuk: Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server