Liron Aravot has submitted this change and it was merged.
Change subject: core: Move getImageInfo call outside of transaction boundary
......................................................................
core: Move getImageInfo call outside of transaction boundary
Currently, when syncing db records, we call vdsm to get volume info.
This call is performed inside db transaction which could lead to failure
regardless of the db performance. This could happen if storage is slow or
network connection is slow.
To fix this behavior, the call to vdsm moved outside of the transaction.
Change-Id: Ifac1ab925afd448d149fecc286d361a797c9d57b
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
3 files changed, 22 insertions(+), 14 deletions(-)
Approvals:
Ala Hino: Verified
Liron Aravot: Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/53605
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifac1ab925afd448d149fecc286d361a797c9d57b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>