Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Fix possible NPE in GetoVirtISOsQuery. ...................................................................... core: Fix possible NPE in GetoVirtISOsQuery. FindBugs issue - GetoVirtISOsQuery.java:186, NP_DEREFERENCE_OF_READLINE_VALUE, Priority: Low Dereference of the result of readLine() without nullcheck in org.ovirt.engine.core.bll.GetoVirtISOsQuery.readVdsmCompatibiltyVersion(String) The result of invoking readLine() is dereferenced without checking to see if the result is null. If there are no more lines of text to read, readLine() will return null and dereferencing that will generate a null pointer exception. Change-Id: I334832b5fefa24de732f919555b3ad26f11b8d08 Signed-off-by: Sharad Mishra <snmishra@linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I334832b5fefa24de732f919555b3ad26f11b8d08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra@linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>