Tal Nisan has submitted this change and it was merged. Change subject: webadmin: override getConsumedEvents of CheckboxCell ...................................................................... webadmin: override getConsumedEvents of CheckboxCell SanStorageLunToTargetList -> addSelectAllButton: update method on the custom ValueUpdater isn't get invoked since CheckboxCell's parent events are overridden on CheckboxCell -> getConsumedEvents (see [1]). Hence, adding parent's consumedEvents on SanStorageLunToTargetList. [1] https://gerrit.ovirt.org/#/c/45444/ Change-Id: Iea76bc58689d608e83554072e871487dc33fb4d8 Bug-Url: https://bugzilla.redhat.com/1215416 Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/46267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea76bc58689d608e83554072e871487dc33fb4d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org