Liron Aravot has submitted this change and it was merged. Change subject: core: Removal of SnapshotType name and I18n improvement ...................................................................... core: Removal of SnapshotType name and I18n improvement Currently the ACTION_TYPE_FAILED_VM_SNAPSHOT_TYPE_NOT_ALLOWED message supports multiple snapshot types set generically to the message. In practice, this message is used with one status only (Regular) and the generification requires specific serialization/deserialization code in the SnapshotType class and lacks i18n support. As this message is used with that status only, this patch updates it to specify it explictly (thus making it i18n compatible), if we'll need to change add support to more types in the future that can be done, right now we can remove that and the related code. Change-Id: I8fb722dd15f0ccc2ac058765bfd6802a2a21134c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304653 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 25 insertions(+), 61 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb722dd15f0ccc2ac058765bfd6802a2a21134c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>