Tal Nisan has submitted this change and it was merged. Change subject: core: Make DiskStorageType values static ...................................................................... core: Make DiskStorageType values static DiskStorageType enum conversion values (for DB storage purposes) was equal to the ordinal value of each enum, relying on the ordinal values is error prone as introducing a new enum not at the end of the chain will cause the ordinals of the enum coming after to shift. This patch sets the conversion values of the enums in DiskStorageType to static ones based on their ordinal and from returns the static values when converting Change-Id: I36f4868e93808e790b87c7e43dc2271e373224de Signed-off-by: Tal Nisan <tnisan(a)redhat.com&gt; --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskStorageType.java 1 file changed, 20 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f4868e93808e790b87c7e43dc2271e373224de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;