Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: fix focus traversal in make template ...................................................................... webadmin: fix focus traversal in make template Fixed the focus traversal in the make template popup dialog: - the focus is switched between the focusable components in the standard order (top to down, left to right) - the focus traversal also include the "ok" and "cancel" buttons This mechanism can be extended in the future to fix the focus traversal in other dialogs. it is especially easy to extend it to other similar popup dialogs (that subclass AbstractModelBoundPopupWidget) - all we need is that its widget will override "setTabIndexes" method and define a custom focus order to its components. Change-Id: I82233e8d136154e942d1ffce8e6f831ddfbfb3fb Bug-Url: https://bugzilla.redhat.com/873133 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundWidgetPopupView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/FocusableComponentsContainer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractModelBoundPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java 8 files changed, 84 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82233e8d136154e942d1ffce8e6f831ddfbfb3fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt;