Ondra Machacek has submitted this change and it was merged. Change subject: Fix writing 'id' attribute for enum values ...................................................................... Fix writing 'id' attribute for enum values Currently the SDK doesn't generate correctly the XML for attributes named 'id' that contain enum values. For example, when writing the list of SSO methods of a virtual machine it generates the following: <sso> <methods> <method> <id>guest_agent</id> </method> </methods> </sso> But it should write the following instead, as the 'id' model attribute should always be represented as an XML attribute: <sso> <methods> <method id="guest_agent"/> </methods> </sso> This patch addresses that issue, which was mostly a typo in the generator of the XML writing code. Change-Id: I52065c9aeba4628155cbdc638bf0334834f4a15d Bug-Url: https://bugzilla.redhat.com/1408839 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com&gt; (cherry picked from commit 7aaafb7bac31622d351b5921e30266656128cfc3) (cherry picked from commit 2e52935a1895f5da8ff0f5f7f95166d1e45228ac) --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java A sdk/tests/test_sso_writer.py 2 files changed, 68 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52065c9aeba4628155cbdc638bf0334834f4a15d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;