Arik Hadas has submitted this change and it was merged. Change subject: core: extract luns related code from vm-analyzer ...................................................................... core: extract luns related code from vm-analyzer VmAnalyzer should (ideally) take a VM that was reported by VDSM, compare it to the previous information we have for that VM and analyze the difference. However, the analyzer currently does more than that and therefore is not easy to maintain. This patch extracts the LUN disks handling from VmAnalyzer to a new class called LunDisksMonitoring. The benefits are: 1. Less not-that-related code in VmAnalyzer and one less DAO to pass to it. 2. We get to the point where the up-to-date dynamic data of the VM is persisted to the database faster as we push one database call per VM that is powering up to be the dynamic VM data is save to the database. Change-Id: I6a5f0410a0684c8785c08d27ed88502822158e85 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/LunDisksMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 5 files changed, 88 insertions(+), 68 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/53718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5f0410a0684c8785c08d27ed88502822158e85 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>