Daniel Erez has submitted this change and it was merged. Change subject: core: GetAllDisksBySD - fetch disks snapshots ...................................................................... core: GetAllDisksBySD - fetch disks snapshots * GetAllDisksByStorageDomainIdQuery: fetch disks' snapshots for calculating the actual size (DiskImage -> getActualDiskWithSnapshotsSize). * Remove redundant GetImagesByStorageId SP. Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10 Bug-Url: https://bugzilla.redhat.com/905595 Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/dbscripts/disk_images_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 5 files changed, 31 insertions(+), 41 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>