Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Vlan id should be shown next to vlan device name
......................................................................
webadmin: Vlan id should be shown next to vlan device name
In order to show the vlan id next to the vlan device name some changes
were done to the host interface sub tab.
1. Removing the address from the brackets next to the vlan device and bond
name.
2. Moving the adress column to the VLanPanel next to the network column.
All the addresses, vlan and non-vlan will be shown in this column.
3. Splitting the Interface panel into two panels- InterfacePanel and
StatisticsPanel. The StatisticsPanel will be the last panel- after the
VLanPanel.
Notice: there were some look-and-feel issues caused to this tab in commit
0248286a6b70ffe9076731aea406fdbfd6a97b0a.
This patch doesn't fix them.
Change-Id: Ia900e7d293df479cd9c98cfe66dcd0cb8b1f4fe4
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
A
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
D
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HostInterfaceBondNameRenderer.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HostVLanNameRenderer.java
9 files changed, 162 insertions(+), 107 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Lior Vernia: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/27631
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia900e7d293df479cd9c98cfe66dcd0cb8b1f4fe4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server