Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Small fix to VnicProfilesEditor ...................................................................... webadmin: Small fix to VnicProfilesEditor As all the changes in the profiles are committed to the model as soon as they happen (adding/removing rows, typing characters) it's unnecessary to flush the widget; it also causes a ghost row to be added the moment "OK" is pressed, so it would be better to avoid this flicker. Also added some javadoc to prevent usage of a method. Change-Id: I504ebef37ef6e3d259cdea8d766a64b4aec51930 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 3 files changed, 7 insertions(+), 9 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I504ebef37ef6e3d259cdea8d766a64b4aec51930 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi@eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server