Alon Bar-Lev has submitted this change and it was merged. Change subject: core: transaction: destructor should be at unmanaged object ...................................................................... core: transaction: destructor should be at unmanaged object The transaction element is a managed object, so there is no need for random destructor, also the abort is not re-entrant. The transaction is unmanaged one and abort is re-entrant, and may enjoy destructor usage for cleanup in case program misbehaves. Reported-By: Simone Tiraboschi <stirabos@redhat.com> Change-Id: I4dce1bb8d09e2bfda5cc6e76339378c33736d5a4 Signed-off-by: Alon Bar-Lev <alonbl@redhat.com> --- M ChangeLog M src/otopi/transaction.py 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dce1bb8d09e2bfda5cc6e76339378c33736d5a4 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: automation@ovirt.org