Einav Cohen has submitted this change and it was merged. Change subject: webadmin,userportal: Fix null-command grid button visibility ...................................................................... webadmin,userportal: Fix null-command grid button visibility Grid buttons whose UICommand is null fall back to using empty (no-op) command singleton object (EMPTY_COMMAND). Previously, EMPTY_COMMAND was declared with IsAvailable and IsExecutionAllowed properties both set to 'false'. This meant that the corresponding UI button was both hidden and disabled. After this patch, EMPTY_COMMAND leaves IsAvailable property to its original value ('true'), so that the corresponding UI button stays visible at all times. Change-Id: Ic04e99901e59bb4fb85afac1e8db22088ecb3f59 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic04e99901e59bb4fb85afac1e8db22088ecb3f59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>