Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Have minus button on every row in AddRemoveRowWidget ...................................................................... webadmin: Have minus button on every row in AddRemoveRowWidget Modified AddRemoveRowWidget to have a minus button on every entry, including the last one. This to enable removing the last row without adding a new one first. When removing the last row though, a plus button needs to be added to the previous one. Also made sure to add a new ghost entry if the removed entry was the only one (this is equivalent to reseting the entry's value to a ghost value). Some styling changes were required to properly display two buttons per entry, where this couldn't happen before. Change-Id: I6f6af3c5a94f7786a9b1e6191f1c36d3181983cf Bug-Url: https://bugzilla.redhat.com/1065978 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 8 files changed, 58 insertions(+), 24 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6af3c5a94f7786a9b1e6191f1c36d3181983cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server