Laszlo Hornyak has submitted this change and it was merged. Change subject: core: fix missing/extra fields in equals() methods ...................................................................... core: fix missing/extra fields in equals() methods While refactoring businessentity equals() methods, some missing and extraneous fields were discovered. Add/remove these fields as needed. (The change to remove fields from VmPool.equals() was borrowed from I17b92858345de398dbc89d9141468ccea67963fe.) Change-Id: I7477f8ee854ca303d0f9de1ea405e1c77a99360d Signed-off-by: Greg Padgett <gpadgett@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java 4 files changed, 7 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7477f8ee854ca303d0f9de1ea405e1c77a99360d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>