Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Propagate error message when quering for LDAP users/groups ...................................................................... engine: Propagate error message when quering for LDAP users/groups Propagating error message when searching AD users/groups via SearchQuery fails, The error is propagated to the webadmin and an inline error message is displayed within the permission view popup. Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699 Signed-off-by: Asaf Shakarchi <asaf@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapReturnValueBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 84 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Asaf Shakarchi: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>