Tal Nisan has submitted this change and it was merged. Change subject: core: preventing NPE on StorageServerConnectionCommandBase ...................................................................... core: preventing NPE on StorageServerConnectionCommandBase Currently we allow to added FCP connections although they aren't supported in oVirt - this has been changed by change 2f7c846 as was required because of how we store the connections password in the DB. After this change in case of added FCP connection, NPE will occur. This patch fixes that by restoring the previous state, we may block adding FCP connections regardless (as having them isn't supported/used by the engine). Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc Bug-Url: https://bugzilla.redhat.com/1176578 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/36456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org