Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Disable revomal of plugged vnic on a running vm
......................................................................
webadmin: Disable revomal of plugged vnic on a running vm
On Networks->Virtual Machines the remove action should be disabled if
the vm is running and the vnic is plugged.
Also, it should be disabled in all the vm states that are not UP or DOWN.
Virtual Machines->Network interfaces already works correctly.
Also a little code fix- there is no need to check the HotPlugEnabled
property when deciding if the user can remove the vnic.
It is enough to make sure the vnic is unplugged. If HotPlug is not enabled
the vnic is always plugged.
Change-Id: I795096615e8ef5118cceb56155aa6806af736ebb
Bug-Url:
https://bugzilla.redhat.com/910021
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java
2 files changed, 14 insertions(+), 15 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/11974
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I795096615e8ef5118cceb56155aa6806af736ebb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>