Tal Nisan has submitted this change and it was merged. Change subject: engine: Re-assign display/migration roles to mgmt network ...................................................................... engine: Re-assign display/migration roles to mgmt network While we recently started marking the management network explicitly as display and migration by default, we did not take care of the scenario where the roles are assigned to another network which is then removed - in which case we're left with no explicit display/migration network, and only fall back to the management network implicitly. Now when a network holding the role is removed, it is re-assigned to the management network. Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Bug-Url: https://bugzilla.redhat.com/1135785 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java 4 files changed, 60 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fe94bdfda672ddf51b075415a02a80ff634a90a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server