Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Fix of FE NPE during too fast clicking at list refresh ...................................................................... userportal: Fix of FE NPE during too fast clicking at list refresh Too fast clicking at refresh button in Basic Userportal or Extended Userportal > VMs could cause nearly concurrent run of callbacks in UserPortla(Basic)ListModel#onVmAndPoolLoad() that resulted in getvms() returning null and thus to NPE. * Filds 'vms' and 'pools' transformed to local variables to prevent concurrent data manipulation. * Methods 'onVmAndPoolLoad' and 'finishSearch' moved to parent class - removing code duplication. Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 121 insertions(+), 242 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5bb5587c09cfb8981e51a6cb3202c4f0a9d174 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org