Maor Lipchuk has submitted this change and it was merged. Change subject: core: support uploading QCOW images. ...................................................................... core: support uploading QCOW images. Currently, uploading a QCOW image is disabled, since there were no security verifications made on a QCOW image after upload finishes. For QCOW images, the system should verify that the uploaded image is actually QCOW, and verify that it does not have a backing file. This is because having a backing file in the new image can expose undesired resources to the user: it can point to any file in the host- including disks of other VMs, etc.. This patch adds a VDS command that calls a VDSM volume verification procedure, and makes the uploaded image legal only after doing this verification- allowing a QCOW format to be chosen in the upload dialog. Change-Id: I6bde0eb732f75afe0fef94aa79bdaab5687b76fd Signed-off-by: Amit Aviram <aaviram@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VerifyUntrustedVolumeVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 8 files changed, 79 insertions(+), 6 deletions(-) Approvals: Amit Aviram: Verified Maor Lipchuk: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bde0eb732f75afe0fef94aa79bdaab5687b76fd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>