Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix NPE in os info ...................................................................... frontend: Fix NPE in os info This patch takes care of console-related methods in AsyncDataProvider. NPE can occur when existing vm is edited, but its OS was removed from os info file. Fixed by handling nulls in AsyncDataProvider and handling non-existent OS case in client code (UnitVmModel). Change-Id: I2aef27aee8e079497c9eaa22dfaa6cb9b5502aae Bug-Url: https://bugzilla.redhat.com/1046809 Signed-off-by: Frantisek Kobzik <fkobzik@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/32981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2aef27aee8e079497c9eaa22dfaa6cb9b5502aae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server