Itamar Heim has submitted this change and it was merged. Change subject: core: clearing snapshot_id on disk detach ...................................................................... core: clearing snapshot_id on disk detach When detaching a DiskImage, the snapshot [1] ID should be cleared. Otherwise, 'DiskImageDAO -> getAllSnapshotsForVmSnapshot' returns floating DiskImages (which shouldn't be taken into account in any flow since they're not relevant with regards to snapshots). Note: when attaching a DiskImage, the snapshot ID is already updated properly according to the VM. [1] only an active snapshot since detaching a disk with snapshots is blocked at canDo phase. Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3 Bug-Url: https://bugzilla.redhat.com/1015170 Signed-off-by: Daniel Erez <derez(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server