Arik Hadas has submitted this change and it was merged. Change subject: core: fix NPE on import template ...................................................................... core: fix NPE on import template A regression that was caused by recent refactoring lead to a NPE in the validation of ImportVmTemplateCommand. The problem was that the ImportValidator was instanciated using its empty ctor, thus the ID of the storage-pool was null when reaching the validation of mac-addresses. This patch fixes this by passing the parameters of the ImportVmTemplateCommand that contain the ID of the storage-pool to the ImportValidator. Change-Id: I133ceca9cb78a3c7bb67a967d9baba53065e7ea4 Bug-Url: https://bugzilla.redhat.com/1336405 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java 5 files changed, 17 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133ceca9cb78a3c7bb67a967d9baba53065e7ea4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>