Tal Nisan has submitted this change and it was merged. Change subject: core: do not pass the context automatically on rollback ...................................................................... core: do not pass the context automatically on rollback In change I310f5f77fff78b3232ee77fe63791425fd521516 CommandBase.attemptRollback() was changed so that instead of accepting a callback as a parameter it automatically clones the current command context and passes it. That changed the previous behavior, as the using commands didn't pass the context. This change isn't documented in the change commit message and affects the rollback, as now the context is passed always the compensation context of the rollback initiating command is used opposed to before. therefore i'm restoring the previous behavior here (null was passed as the context for the callback). Change-Id: I02cd0bf6ff89591f5f62741200b5620ac96fbd90 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284250 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/48931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02cd0bf6ff89591f5f62741200b5620ac96fbd90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>