Change in ovirt-engine[ovirt-engine-3.3]: backend: Remove duplicate read of TimeZone in OvfVmReader

Itamar Heim has submitted this change and it was merged. Change subject: backend: Remove duplicate read of TimeZone in OvfVmReader ...................................................................... backend: Remove duplicate read of TimeZone in OvfVmReader Removed duplicate read of TimeZone ovf-field which was not sanitized against empty strings causing creation of Vm with invalid timezone "" (correctly should be normalized to null). Also removed the temporary fix in TimeZoneValidator since now all cases should be covered and the empty string time-zone always normalized to null. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015049 Change-Id: I9152bc347a5358ca794ee8c237e4486f444862ee Signed-off-by: Martin Betak <mbetak@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/TimeZoneValidator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9152bc347a5358ca794ee8c237e4486f444862ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server
participants (1)
-
iheim@redhat.com