Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Extended view/Basic view visibility fixes ...................................................................... userportal: Extended view/Basic view visibility fixes There where two problems with determining, if the Extended view should be shown or not: 1: The Everyone has a QuotaConsumer role which enabled everyone to see the Extended view. Fixed by ignoring the Everyone QuotaConsumer when deciding if show or not show the extended view 2: After logout/login as user with different role, the visibility of the header buttons (Basic, Extended) was not updated. Fixed by moving the code which refreshes this from HeaderPresenterWidget.onBind to HeaderPresenterWidget.onReset because the HeaderPresenterWidget is a singleton. This patch also contains the creating of the enum named ApplicationGuids which contains some well known values from ad_groups and roles tables and also the refactoring of places which used this values directly to use them from the enum. Change-Id: I16ec262e7e5b46ccfdba28d091726d8368cae054 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java 10 files changed, 77 insertions(+), 43 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ec262e7e5b46ccfdba28d091726d8368cae054 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com>