From Arik Hadas <ahadas@redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79589 ) Change subject: core: use ovf:href instead of ovf:fileRef to identify disk id ...................................................................... core: use ovf:href instead of ovf:fileRef to identify disk id According to the OVF specification, ovf:fileRef attribute of a disk should point to the ovf:id attribute of a File element within the References section. However, we used that attribute exactly as the ovf:href attribute of a File element so it was also used to retrieve the disk's (image group's) id. This patches changes that so ovf:href will be used instead. We should note that we still can't change the content of ovf:fileRef to something else than the relative path of the volume because previous versions still count on that. Change-Id: I2b3a8f379a68ad089547f85d8d93d2bbb5213c54 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 1 file changed, 4 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b3a8f379a68ad089547f85d8d93d2bbb5213c54 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>