Allon Mureinik has submitted this change and it was merged. Change subject: core: rv GetEntityPermissionsi[ForUserAndGroups] ...................................................................... core: rv GetEntityPermissionsi[ForUserAndGroups] Change get_entity_permissions and get_entity_permissions_for_user_and_groups to use a return value instead of an output parameter. Although the main reasoning behind this is standardisation and code cleanliness, there is an added performance bonus as this change removes an explicit conversion of the returned uuid to a varchar. Change-Id: I26d94fc765c927763af6bb0fa6775b4aaced6a28 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java M packaging/dbscripts/multi_level_administration_sp.sql 2 files changed, 15 insertions(+), 25 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26d94fc765c927763af6bb0fa6775b4aaced6a28 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server