Allon Mureinik has submitted this change and it was merged. Change subject: core: ProcessOvfUpdateForStoragePoolCommand#loadConfigValue ...................................................................... core: ProcessOvfUpdateForStoragePoolCommand#loadConfigValue loadConfigValue was an artificial method that had exactly one use - to be mocked out by the test. This patch removes this useless method and replaces its mocking with the project's standard MockConfigRule. Change-Id: I7137c5b86870d66cd25d8db8e194938362cb4cb8 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7137c5b86870d66cd25d8db8e194938362cb4cb8 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>