Change in ovirt-engine[master]: core: UnPowerMock VdsUpdateRunTimeInfoTest

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: UnPowerMock VdsUpdateRunTimeInfoTest ...................................................................... core: UnPowerMock VdsUpdateRunTimeInfoTest Remover PowerMock depedency from VdsUpdateRunTimeInfoTest. In order to acheive this improvement, some refactoring was required in EjbUtils and VdsUpdateRunTimeInfo intself. EjbUtils is mocked by setting the inner strategy object and returning it back to the original obejct after the test is done. If this method is deemed acceptable, perhaps it would be a good idea to extrat it to its own @Rule. Change-Id: I5519a02c197b0ef09a9cabd37e6fa90dbecc0897 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EjbUtils.java M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsUpdateRunTimeInfoTest.java 4 files changed, 116 insertions(+), 70 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5519a02c197b0ef09a9cabd37e6fa90dbecc0897 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>
participants (1)
-
lhornyak@redhat.com