Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: no way to set instance type ...................................................................... webadmin: no way to set instance type When selected an instance type it was reset to "custom" immediately. The regression has been introduced by https://gerrit.ovirt.org/#/c/41486/2 by call getListModel().setSelectedItem(null); from EntityModelCellTable which fires the events outside of the control of the models. Since this broke the VM dialog already second time the fix was to rewrite the priority to use list box instead of EntityModelCellTable. This patch also adds the callback to PriorityUtil so the caller can activate/deactivate the instance type manager as needed. Last change was to change the watchdog panel so it looks consistently with the rest of the dialog (the difference became obvious after changing the priority to list box). Change-Id: I6127fb69c8b201e56ab1f13e28448c9fdebc4196 Bug-Url: https://bugzilla.redhat.com/1241403 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PriorityUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 5 files changed, 68 insertions(+), 29 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6127fb69c8b201e56ab1f13e28448c9fdebc4196 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org