Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup CreateVmVDSCommand
......................................................................
core: cleanup CreateVmVDSCommand
- Refactor CreateVmVDSCommand#ExecuteVdsIdCommand method to be with less
nested levels and to have more readable structure
- Reduce duplicate code at CreateVmVDSCommand#ExecuteVdsIdCommand by
extracting the variability to external method: initCreateVDSCommand
- Rename private methods names in this class to start with lowercase
Change-Id: I8159dbfd351ea460d01c56553cfe3219d960c8b7
Bug-Url:
https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
1 file changed, 55 insertions(+), 63 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/15681
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8159dbfd351ea460d01c56553cfe3219d960c8b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server