From Arik Hadas <ahadas@redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/81048 ) Change subject: core: Memory devices spec param size in MiB ...................................................................... core: Memory devices spec param size in MiB Memory device spec params 'size' uses MiB unit even with libvirt domain xml. Without libvirt xml it used MiB (vdsm: lib.vdsm.virt.vmdevices.core.Memory#from_xml_tree) and till this patch with libvirt xml it temporarily used KiB. Previewing snapshot created in period when using KiB might cause problems but this bug wasn't in any released version. Change-Id: I00382b1013e2a5be5d8306a81f27b2300165f642 Bug-Url: https://bugzilla.redhat.com/1482042 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/81048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00382b1013e2a5be5d8306a81f27b2300165f642 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>