Allon Mureinik has submitted this change and it was merged. Change subject: core: unify and move Disk Comparators ...................................................................... core: unify and move Disk Comparators Organized the various Disk and DiskImage comparators in a sensible manner. 1. Moved DiskImageByDiskAliasComparator from the dal module to the common module, so it could be shared between modules. 2. Removed ImagesComparerByName which had exactly the same functionality as DiskImageByDiskAliasComparator, and used it instead. 3. Converted DiskImageByBootComparator to be an inline class of VmInfoBuilderBase, as it seems useless outside it Change-Id: Ide5808ba4404d141f43911945e19f170e9694da4 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTopSizeVmsFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdQuery.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/DiskImageByDiskAliasComparator.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/ImagesComparerByName.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 8 files changed, 24 insertions(+), 49 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide5808ba4404d141f43911945e19f170e9694da4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>